London | 26-ITP-Sep| Mandip Sanger | Sprint 2 | Coursework - #1469
mandipsanger wants to merge 26 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, I have some comments about this one though
abdishakoor-dev
left a comment
There was a problem hiding this comment.
There are still a lot of issues to fix before this PR can be closed. I am going to help you out a bit, but you need to pay close attention to the questions and feedback you are getting.
-
2-mandatory-errors/0.jshas not been started. Put//at the start of lines 1 and 2. -
1-percentage-change.jsline 5 is missing a comma. ChangereplaceAll("," "")toreplaceAll(",", "")and the file will run. -
1-percentage-change.jsc) asks which lines are reassignments. The answer is lines 4 and 5. What you have under c) now is the answer to b), so move it to b). -
2-time-format.jsline 32 says the code works for all values. It does not. It works for non-negative whole numbers, which is what you wrote in your reply on this PR. Put that in the file. -
2-mandatory-errors/1.js. The fix is right, but the section also asks you to explain the error, and you have not done that anywhere yet. Run the original and node printsTypeError: Assignment to constant variable.It happens becauseageis aconst, and aconstcannot be given a new value. Write that down, either in the file as a comment or as a reply here. Whichever you prefer. -
2-mandatory-errors/4.js. The renaming is right, but your comments explain how to convert 12 hour time into 24 hour time, which is a different question. The error isSyntaxError: Invalid or unexpected token, because a variable name cannot start with a digit. Explain that instead, again either in the file or as a reply here.
Your explanation in 4-random.js is well done.
Run each file once after you change it. Add the Needs Review label when you have pushed.
There was a problem hiding this comment.
Points 1, 2, 3 and 5 are done, and every file runs now. Thank you.
Two things are still open:
2-time-format.jslines 32 and 33 still say the code works for all values. This is the third time we have asked about f). Delete lines 32 and 33. In their place, copy the two sentences from your reply on 17th Sep:the code will not work correctly for all values of movieLength.
It works correctly for non-negative whole numbers (integers) representing seconds.
2-mandatory-errors/4.js: see my comment on line 4.
When you push these, I will mark this PR Complete. Add the Needs Review label again when you have pushed.
| const twelveHourClockTime = "8:53pm"; | ||
| const twentyFourHourClockTime = "20:53"; | ||
|
|
||
| // 12 Hour clock time is a string that represents the time in 12-hour format, while 24hourClockTime is a string that represents the time in 24-hour format. |
There was a problem hiding this comment.
Line 10 answers the question. Lines 4 to 9 answer a different question: how to convert 12 hour time. Delete lines 4 to 9.
There was a problem hiding this comment.
I can't see the original file which question was asked so trying to download the original file.
There was a problem hiding this comment.
I have deleted lines 4 to 9 please see if it shows.
There was a problem hiding this comment.
Sorry I didnt see this comment. There were so many feedback.

Self checklist
Task code
CYF-1039
Changelist
adding files for sprint 2 coursework